Partially registries merge #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarastqt
reviewed
Dec 29, 2018
packages/di/di.tsx
Outdated
| * | ||
| * @param registry external registry | ||
| */ | ||
| merge(registry?: Registry) { |
There was a problem hiding this comment.
А зачем registry является опциональным? Ты ведь ниже делаешь мердж с пустым объектом, кажется, что это не особо имеет смысл
| expect(registry.merge(overrides).snapshot()).to.eql(snapshot); | ||
| }); | ||
|
|
||
| it('should not affect registry in merge with undefined', () => { |
There was a problem hiding this comment.
В покрытии 100% ;)))
awinogradov
force-pushed
the
dynamicaly-merge
branch
from
86a5ad5
to
96bb165
Compare
yarastqt
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.